[Fix] Fix MultiTableSink restore failed when add new table #5746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hisoka-X
commented
Oct 30, 2023
| @@ -217,13 +217,13 @@ public SnapshotPhaseState snapshotState(long checkpointId) { | |||
| new SnapshotPhaseState( | |||
| alreadyProcessedTables, | |||
| remainingSplits.isEmpty() | |||
| ? Collections.emptyList() | |||
There was a problem hiding this comment.
Use unmutable list will throw exception when restore with add new table. So I think we should use mutable list for now. cc @hailin0
hailin0
previously approved these changes
Oct 31, 2023
| @@ -217,13 +217,13 @@ public SnapshotPhaseState snapshotState(long checkpointId) { | |||
| new SnapshotPhaseState( | |||
| alreadyProcessedTables, | |||
| remainingSplits.isEmpty() | |||
| ? Collections.emptyList() | |||
hailin0
approved these changes
Nov 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
This PR fix MultiTableSink restore failed when add new table in source side.
Does this PR introduce any user-facing change?
no
How was this patch tested?
add new test.
Check list
New License Guide
release-note.